This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Make destructor virtual to avoid object splicing during destructor #9035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refs #8906 |
jfirebaugh
approved these changes
May 18, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3f0c89d introduced a
GeoJSONDataobject that is held in aunique_ptr, and has two child classes with data members. However, theunique_ptrcreated only holds the parent object, and it doesn't have a avirtualdestructor, which means that during destruction, it'll only delete the base class part of the object (probably empty due to empty base optimization), which leaves the other data members defined by the child classes (GeoJSONVTorSupercluster) allocated, creating a memory leak./cc @tmpsantos @bsudekum